Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing unit tests for getValidUploads function #471

Open
as1729 opened this issue Oct 3, 2024 · 0 comments
Open

Add missing unit tests for getValidUploads function #471

as1729 opened this issue Oct 3, 2024 · 0 comments
Assignees
@greg-adams
Labels
CPF Quarterly Reporter good first issue Good for newcomers

Comments

@as1729
Copy link
Contributor

as1729 commented Oct 3, 2024 •
edited
Loading

See #470

An existing branch and draft pull requests already for this issue. The goal is to complete this draft PR and get it ready for review with all tests passing.

The cases needed to be tested are:

  1. When an upload was first validated and subsequently invalidated then it should be ignored.
  2. When an upload was first invalid and subsequently became valid then it should be included.
  3. When an upload has multiple valid UploadValidation records it should be included.
  4. When an upload only has a single valid UploadValidation record it should be included.
  5. When an upload only has a single invalid UploadValidation record it should be ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg-adams greg-adams

Labels
CPF Quarterly Reporter good first issue Good for newcomers
Projects
Grants Team Agile Planning
Status: 🚢 Completed
Milestone
No milestone
2 participants
@as1729 @greg-adams