Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use checkboxes unless you have a form. #372

Open
mgifford opened this issue Aug 21, 2021 · 0 comments
Open

Don't use checkboxes unless you have a form. #372

mgifford opened this issue Aug 21, 2021 · 0 comments

Comments

@mgifford
Copy link

Bug Report

Looking here https://smeqa.usds.gov/hiring-phases/resume-review/training/

this really isn't a best practice.

<li>
        <input type="checkbox" name="item1">&nbsp;<a href="/toolkit/resume-review/resume-review-training-agenda/">Training agenda</a></li>

If you want a checkbox, would be probably better to either make the list unstyled and use unicode ▢ or put it into your CSS:

ul {
  list-style: none;
  margin-left: 0;
  padding-left: 0;
}

li {
  padding-left: 1em;
  text-indent: -1em;
}

li:before {
  content: "▢";
  padding-right: 5px;
}

But use semantic html. This isn't supposed to be a form. It does nothing and has no interaction.

If you want it to be a form, then make it properly into a form.
AutomatedChecks_20210821_SubjectMatterExpertQ (1).html.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant