Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Foundation classes from USFS when USWDS 2.0 is released #57

Closed
annekainicUSDS opened this issue May 25, 2018 · 8 comments
Closed
Labels
BLOCKED [external] [practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues

Comments

@annekainicUSDS
Copy link
Contributor

Now that new version of USWDS will soon include more grid support, go back through and remove Foundation classes.

@annekainicUSDS annekainicUSDS added [practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues labels May 25, 2018
@jcmeloni-usds
Copy link
Contributor

This will be amazing.

I think this should warrant a specific note in a "known issues" or "important upcoming changes" or some such for public consumption -- what do you think @ju-liem ?

@jcmeloni-usds
Copy link
Contributor

@ju-liem Let's ensure that the current state of this is documented in the wiki as a known issue/dependency that we're prioritizing removing as soon as we can -- and if we know when that will be because USWDS tells us, let's include that! Might just ask them.

@annekainicUSDS
Copy link
Contributor Author

This is blocked until USWDS releases version 2.0, because that will provide the grid support we need and currently import from Foundation.

@jcmeloni-usds
Copy link
Contributor

@fatima-gov @annekainicUSDS Do either of you have the latest info on the status of the USWDS 2.0 branch? Tons of commits since the alpha branch was originally pushed out, but I haven't been on the USWDS calls to get the latest.

@annekainicUSDS
Copy link
Contributor Author

@jcmeloni-usds I don't have any more updated information, last I heard it was still being worked out, but I haven't heard a release date yet.

@jcmeloni-usds
Copy link
Contributor

Ok thanks!

@jcmeloni-usds jcmeloni-usds changed the title Remove Foundation Remove Foundation classes from USFS when USWDS 2.0 is released Sep 19, 2018
@jcmeloni-usds jcmeloni-usds removed their assignment Oct 25, 2018
@jcmeloni-usds
Copy link
Contributor

Let's not forget this!

@dmethvin-gov
Copy link
Contributor

This is most likely to occur as part of #66, since it would be a breaking change for anyone using the library currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED [external] [practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues
Projects
None yet
Development

No branches or pull requests

4 participants