Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Support --anvil.* flags #1358

Merged
merged 11 commits into from
Sep 19, 2024
Merged

feat(cli): Support --anvil.* flags #1358

merged 11 commits into from
Sep 19, 2024

Conversation

saeta-eth
Copy link
Contributor

@saeta-eth saeta-eth commented Sep 6, 2024

This PR makes a clearer distinction between Cannon and Anvil flags by prefixing Anvil flags with --anvil.*, improving clarity and making their origin explicit. It also includes the upgrade to the latest version of Commander.

Closes https://linear.app/usecannon/issue/CAN-508/add-foundry-params-to-all-cannon-commands-with-forge-and-anvil

Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: de2af04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth saeta-eth changed the title feat(cli): support --anvil.* notation for Anvil flags feat(cli): support --anvil.* notation for Anvil flags Sep 6, 2024
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be really cool if we could progmatically just pass any arguments based on if they start with --anvil. prefix rather than having to code them here (that way if they add/change arguments in the future, it always works with user's setup)

@saeta-eth
Copy link
Contributor Author

saeta-eth commented Sep 10, 2024

would be really cool if we could progmatically just pass any arguments based on if they start with --anvil. prefix rather than having to code them here (that way if they add/change arguments in the future, it always works with user's setup)

I get what you’re saying and I tend to agree but I found two reasons to keep them in the code: 1- they’re used in the docs on the website, 2- if someone mistypes a flag, commander suggests the right one

@saeta-eth saeta-eth marked this pull request as ready for review September 10, 2024 15:05
@saeta-eth saeta-eth added the enhancement New feature or request label Sep 10, 2024
@mjlescano mjlescano changed the base branch from main to dev September 16, 2024 14:52
@saeta-eth saeta-eth changed the title feat(cli): support --anvil.* notation for Anvil flags feat(cli): Support --anvil.* flags Sep 18, 2024
@saeta-eth saeta-eth merged commit 6d71328 into dev Sep 19, 2024
6 of 8 checks passed
@saeta-eth saeta-eth deleted the chore/upgrade-commander branch September 19, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants