Adds git sha scope for variable injection #211
Conversation
| case "$INJECT_GIT_SHA" in | ||
| true|both) | ||
| LAGOON_GIT_SHA=$GIT_SHA | ||
| LAGOON_BUILD_GIT_SHA=$GIT_SHA | ||
| ;; | ||
| build) | ||
| LAGOON_BUILD_GIT_SHA=$GIT_SHA | ||
| LAGOON_GIT_SHA="0000000000000000000000000000000000000000" | ||
| ;; | ||
| runtime) | ||
| LAGOON_BUILD_GIT_SHA="0000000000000000000000000000000000000000" | ||
| LAGOON_GIT_SHA=$GIT_SHA | ||
| ;; | ||
| *) | ||
| LAGOON_GIT_SHA="0000000000000000000000000000000000000000" | ||
| LAGOON_BUILD_GIT_SHA=$LAGOON_GIT_SHA | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
My only concerns with this are that the environment_variables.git_sha field goes from being a boolean, to a string. I think it is ok though.
Edit: And this field isn't in the go rewrite yet either, so I'm more comfortable with it changing now before it gets merged into the newer code base.
|
Maybe it makes sense to just set There is also the |
This PR suggests a way of controlling scope for the GIT_SHA variable, as described in #210
Closes #210