Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectively apply ingress objects, only when there is a change. Avoid the double apply #320

Open
seanhamlin opened this issue May 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@seanhamlin
Copy link
Contributor

At present, if you have a lot of domains defined in your .lagoon.yml file (in this case > 400), a deployment can take a long time to run through.

The most impacted steps of the deployment are:

Route/Ingress Configuration (Duration: 00:12:47)
...
Backup Configuration (Duration: 00:12:14)

The total deployment duration was 25m 41secs, so the above 2 steps account for 97.4% of the deployment time.

Ideal scenario

  • Only apply ingress objects when there is a change that needs to be applied (e.g. adding a new domain, deleting a domain, some form of annotation change)
  • Ingress objects are only applied once
@seanhamlin seanhamlin added the enhancement New feature or request label May 29, 2024
@shreddedbacon
Copy link
Member

shreddedbacon commented May 29, 2024

This is partially resolved in the helm replacement branch by reducing the number of times that the apply takes place

@shreddedbacon
Copy link
Member

I would also recommend that if you have 400 routes or ingress objects, that you look to try to consolidate as many of these using the alternativeNames feature to reduce the overall number of ingress objects that would be created.

@shreddedbacon
Copy link
Member

  • Only apply ingress objects when there is a change that needs to be applied (e.g. adding a new domain, deleting a domain, some form of annotation change)

This will come to a degree, but its difficult to know what is changed and what hasn't changed without first analyzing the namespace ingress objects. Which would also add time to the process. There are some tradeoffs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants