Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Images Aggressively Cropped #330

Open
BoffinBrain opened this issue Dec 18, 2024 · 2 comments
Open

Preview Images Aggressively Cropped #330

BoffinBrain opened this issue Dec 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@BoffinBrain
Copy link

I've just started migrating over from UserStyles.org so I figured I'd report this as I go.

On both the regular and the 'redesigned' style view page, the preview image container has a hard-coded height. If the preview image or screenshot doesn't exactly match the aspect ratio of the container, it's cropped at the top and bottom, with no way to see the rest:

Screenshot 2024-12-18 at 00-17-42 MixCloud Accessibility Fixes — UserStyles world

This can be fixed by removing align-items: center; from .card .screenshot picture in the CSS. Given that the screenshot container includes a blurred version, I assume this was the intended way to display it:

Screenshot 2024-12-18 at 00-18-03 MixCloud Accessibility Fixes — UserStyles world

Browser: Firefox 134 on Windows

@BoffinBrain BoffinBrain added the bug Something isn't working label Dec 18, 2024
@astyled
Copy link
Contributor

astyled commented Dec 18, 2024

I assume this was the intended way to display it

It is. For small images. Not sure about the large ones.

Please note that Stylus crops previews even more aggressively, and USw crops previews in the listing (explore, search, etc) too, so you may want to stick to 16:9 with some vertical margin for content for good readability.

@BoffinBrain
Copy link
Author

Yes, I saw that the USw listing previews are similarly cropped, although with those it aligns them at the top, cropping off the bottom of the picture. This makes more sense. Still worth doing the one-line change though, IMO. Not everyone will be aware of the cropping or know how to optimize their screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants