Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm posts were successfully sent to the server before emptying the offline posts array in localStorage #10

Open
NidhiKJha opened this issue Aug 19, 2019 · 4 comments

Comments

@NidhiKJha
Copy link
Contributor

NidhiKJha commented Aug 19, 2019

In form.js

formDataArray.map(formData => { postFormData(formData, this.state.token.access_token); }); localStorage.removeItem("Failed Form Submission Data");

Ensure the localStorage is removed only after the data is sent successfully.

@NidhiKJha NidhiKJha mentioned this issue Aug 20, 2019
@rowasc rowasc changed the title Ensure localStorage is emptied after posts are sent Confirm posts were successfully sent to the server before emptying the offline posts array in localStorage Aug 24, 2019
@rowasc
Copy link
Collaborator

rowasc commented Aug 24, 2019

Editing for more clarity on what's left here

@NidhiKJha
Copy link
Contributor Author

This is now part of the pull request here #9.
The enhancement is working so far in my local testing.

@rowasc
Copy link
Collaborator

rowasc commented Sep 5, 2019

@all-contributors please add @NidhiKJha for code and doc

@allcontributors
Copy link
Contributor

@rowasc

I've put up a pull request to add @NidhiKJha! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants