Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MainSolver API #688

Open
Tomaqa opened this issue Mar 25, 2024 · 1 comment · Fixed by #689
Open

Fix MainSolver API #688

Tomaqa opened this issue Mar 25, 2024 · 1 comment · Fixed by #689
Assignees
@Tomaqa
Labels
priority:low Low priority issue

Comments

@Tomaqa
Copy link
Member

Tomaqa commented Mar 25, 2024

The public API should not expose private classes and functions.
Also add appropriate checks for the existing API calls.
@Tomaqa Tomaqa self-assigned this Mar 25, 2024
@Tomaqa Tomaqa mentioned this issue Mar 25, 2024
Merged
@Tomaqa Tomaqa linked a pull request Mar 25, 2024 that will close this issue
Fix some access levels in MainSolver and add some checks to public … #689
Merged
@Tomaqa
Copy link
Member Author

Tomaqa commented Mar 26, 2024

The issue is not fully resolved yet. For example, the SMT solver and THandler should not be necessary to be included in the public API. Not speaking of the initialization of MainSolver where for example it first constructs thandler and then constructs logic(thandler->getLogic())

@Tomaqa Tomaqa reopened this Mar 26, 2024
@Tomaqa Tomaqa added the priority:low Low priority issue label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tomaqa Tomaqa

Labels
priority:low Low priority issue
Projects
None yet
Milestone
No milestone
1 participant
@Tomaqa