From a3bbe41286fe1a75f8eecb9137e944dac3dda02b Mon Sep 17 00:00:00 2001 From: jasonchung1871 <101672465+jasonchung1871@users.noreply.github.com> Date: Mon, 26 Aug 2024 21:41:52 -0700 Subject: [PATCH] refactor: Forms 1124 composition api infolinks (#1473) * Update GeneralLayout and FormComponentsProactiveHelp GeneralLayout has been updated to the composition API with almost full coverage, did not add coverage for the HTML FormComponentsProactiveHelp was updated to the composition API but no coverage was added, it was just confusing deciphering what was happening in the file so it was refactored. * Update ProactiveHelpDialog ProactiveHelpDialog updated to the composition API and test coverage has been added excluding FileReader testing and vue watch changes. * Update ProactiveHelpDialog.vue awaiting addFCProactiveHelp * Update ProactiveHelpPreviewDialog ProactiveHelpPreviewDialog is updated to the composition API and should have coverage excluding the watch variable --- .../admin/FormComponentsProactiveHelp.vue | 224 ++++--------- .../components/infolinks/GeneralLayout.vue | 302 +++++++++--------- .../infolinks/ProactiveHelpDialog.vue | 265 ++++++++------- .../infolinks/ProactiveHelpPreviewDialog.vue | 57 ++-- app/frontend/src/utils/constants.js | 65 ++++ .../admin/FormComponentsProactiveHelp.spec.js | 25 +- .../infolinks/GeneralLayout.spec.js | 297 +++++++++++++++-- .../infolinks/ProactiveHelpDialog.spec.js | 212 +++++++++++- .../ProactiveHelpPreviewDialog.spec.js | 45 ++- 9 files changed, 963 insertions(+), 529 deletions(-) diff --git a/app/frontend/src/components/admin/FormComponentsProactiveHelp.vue b/app/frontend/src/components/admin/FormComponentsProactiveHelp.vue index 844c89b78..e424f2922 100644 --- a/app/frontend/src/components/admin/FormComponentsProactiveHelp.vue +++ b/app/frontend/src/components/admin/FormComponentsProactiveHelp.vue @@ -1,172 +1,80 @@ - diff --git a/app/frontend/src/components/infolinks/GeneralLayout.vue b/app/frontend/src/components/infolinks/GeneralLayout.vue index 10284a5f4..002279cd9 100644 --- a/app/frontend/src/components/infolinks/GeneralLayout.vue +++ b/app/frontend/src/components/infolinks/GeneralLayout.vue @@ -1,138 +1,144 @@ - diff --git a/app/frontend/src/components/infolinks/ProactiveHelpDialog.vue b/app/frontend/src/components/infolinks/ProactiveHelpDialog.vue index 99b54a85b..3aff3a9d8 100644 --- a/app/frontend/src/components/infolinks/ProactiveHelpDialog.vue +++ b/app/frontend/src/components/infolinks/ProactiveHelpDialog.vue @@ -1,131 +1,154 @@ -