Date/Time format coherence in pickatime/pickadate #237
Comments
|
I think there aren't many options here, outside of adding those variable to settings.py. The only thing I can think off would be to also try to manually convert from js to pickadate's limited format, if possible. It would only attempt to convert if the new variables are not set in settings.py |
rptmat57
added a commit
that referenced
this issue
Jun 19, 2024
* Pickadate format now based on js format. Closes #237 * Pickadate format conversion: remove additional unsupported formats. * Pickadate format conversion: fix submit format. * Pickadate format: rename variable. * Pickadate format: remove additional hardcoded value. * Pickadate format: fix unsupported removal order. * Pickadate format: fix typo. * Pickadate format: fix typo. * Pickadate format: remove duplicated formats. * Pickadate format: improved logic. Also renamed variables. * Update NEMO/apps/kiosk/templates/kiosk/tool_reservation.html * Update NEMO/templates/mobile/new_reservation.html * fixed wrong format for date --------- Co-authored-by: Mathieu Rampant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Mathieu,
I noticed hard-coded date/time formatting in kiosks( 1, 2, 3) and mobile view (4, 5).
I was going to submit a PR to make them coherent with all other Django and Fullcalendar variables defined in
settings.py, but I soon realized that pickadate library uses another formatting for time and date, which is different from both Django and FullCalendar.How would you suggest to proceed? Shall I add an two additional variables to settings.py?
The text was updated successfully, but these errors were encountered: