Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentEntries get deprecateded after two "normal" uptades (ITI-57) in Registry simulator #591

Open
patrick-peer opened this issue Aug 2, 2023 · 4 comments
Assignees

Comments

@patrick-peer
Copy link

When I update a Document Entry with ITI-57 in a Registry simulator everything works as expected: The registry contains two Document Entries with the same uniqueId, the old one with Availability Status Deprecated, and the new one with Availability Status Approved.
However, when I update the same Document Entry a second time, the Registry simulator contains three Document Entries, every single one having the Availability Status set to Deprecated.

@patrick-peer
Copy link
Author

As far as I can tell, my ITI-57 requests should not be the cause for this behaviour, i.e. they do no update the Availability Status. FWIW here is a set of requests, that caused the involuntary deprecation, though:
ITI_57_UpdateDocumentSet_Request_1.txt
ITI_57_UpdateDocumentSet_Request_2.txt

@andrewmccaffreynist
Copy link
Member

andrewmccaffreynist commented Aug 4, 2023 via email

@patrick-peer
Copy link
Author

I have no software ready to query for deprecated Document Entries, nor do I know of a way how to extract them from the toolkit => I simply took screenshots of the results from the SimIndexInspector.

I grouped the requests with the resulting changes in the registry (as screenshots) in folders in the attached Zip file [1]. The updated field is DocumentEntry.comments [2].

[1] involuntaryDeprecate.zip
[2] https://profiles.ihe.net/ITI/TF/Volume3/ch-4.2.html#4.2.3.2.4

@skbhaskarla
Copy link
Collaborator

I found the problem in the Toolkit code. This problem was stemming from changes related to "Adding CP 1190-02 support (Update deprecated DE through RMU)." The code pulls all versions of registry objects with the same DocumentEntry UID but the method always returned only one entry version, in this case the deprecated version 1 not all versions. The fix will be to return correct list of registry objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants