Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater broken due to userstyles.org update #50

Closed
decembre opened this issue Aug 17, 2023 · 58 comments
Closed

Updater broken due to userstyles.org update #50

decembre opened this issue Aug 17, 2023 · 58 comments

Comments

@decembre
Copy link

decembre commented Aug 17, 2023

As i said:
i can't login and so... i can't update my userstyles in it.
Their new design break the login function, which only act as we want Create an account.
From Stylus Help on Discord , Mikey said:

"At first, I don't even get that far—it just redirected me to the home page whenever I tried to sign in.

Then something else made perfect sense once I got their new design. 
They removed ALL data from their API except userstyle IDs, which in turn breaks USo-archive. 
You can check the repository and see for yourself.
 I can't tell for sure whether or not that was intentional. 
Either way, it wouldn't surprise me if they broke signing in while they were at it.

Judging from how things work in the redesign, they appear to have switched to Firebase. 
The home page gets a 90 KB gzipped (350 KB raw) JSON file with all the userstyle data. 
That's just ridiculous. 
What makes it worse is that I couldn't find an endpoint that returns one userstyle rather than a collection of them"
@33KK
Copy link
Collaborator

33KK commented Aug 21, 2023

The website doesn't even work

@Atexor
Copy link

Atexor commented Aug 30, 2023

Website doesn't work for me on Firefox, it instantly goes blank. On Chrome (still) work. I don't know I have no idea what kind of idiot programmers they have, but even when website "worked", there was a pop-up panel to send opinions and reviews about site but sending button doesn't work. Discord link to USO is invalid, I have written e-mail and sent it twice to 2 e-mails from UserStyles (hoping they still work because in the past I got reply from them). It passed over 2 weeks and no reply. I think the site is now completely dead.

@33KK
Copy link
Collaborator

33KK commented Aug 30, 2023

Website doesn't work for me on Firefox, it instantly goes blank.

Yep that's exactly what happens to me too

On Chrome (still) work

Bromite on my phone doesn't.

I guess I should just turn off the updater and rollback the broken updates, and deal with fixing it later if the website itself works.

@vednoc
Copy link

vednoc commented Sep 4, 2023

To fix the blank page issue, go to https://userstyles.org/categories/site, then click on their new logo to go to the home page and make redesign persistent (or click on one of the categories, then click on the home button, as it doesn't appear to work every single time). They broke things with their redesign, as per quoted message.

@decembre
Copy link
Author

decembre commented Sep 4, 2023

That's really strange how they broke all their site without doing anything ....

Without said of their version for Chrome or Quantum,
the worst thing is for me with Waterfox Classic.

Before i can login (with their new Design) by using the OLD profile account page (which staying in OLD design) and Edit / update my userstyles.
Now it's impossible, i lost the old account page, can't login (their login form only create a new account).

And if i want open an userstyle, i have a blank page with error message:
"Application error: a client-side exception has occurred (see the browser console for more information)."

@vednoc
Copy link

vednoc commented Sep 4, 2023

They don't care. This isn't the first time they redesigned their website and broke a lot of things in the process. The history repeats itself.

@decembre
Copy link
Author

decembre commented Sep 4, 2023

hmm yes, i know.

USO Archives "was" one solution against their lake of support.

The problem is that i lost the history of my install etc.

And sometime i need install an userstyle with my old version of Stylish:
by example for my Dark and minimal version of scrollbar (for Waterfox Classic and Firefox >57),
which can't be installed with Stylus.
At least, as i understand in the reply to my request:
Why i can't install this userstyles: Firefox - Slim Dark Scrollbar with Stylus ?

@33KK
Copy link
Collaborator

33KK commented Sep 4, 2023

To fix the blank page issue, go to https://userstyles.org/categories/site, then click on their new logo to go to the home page and make redesign persistent (or click on one of the categories, then click on the home button, as it doesn't appear to work every single time). They broke things with their redesign, as per quoted message.

Well that did work, fixing this seems easy enough, I'll look into it later.

@33KK
Copy link
Collaborator

33KK commented Sep 4, 2023

Actually wait, they removed the "Recently Updated" sorting option it seems, not sure how to fix this then.

EDIT: I guess I could use the old API to get updated userstyle ids and ... nevermind, direct links to styles are literally broken right now.

@33KK 33KK changed the title Should Broke USO Archive: Update impossible in Userstyle.org (I can't login in it with any browser) Updater broken due to userstyles.org update Sep 4, 2023
@33KK 33KK pinned this issue Sep 4, 2023
@vednoc
Copy link

vednoc commented Sep 4, 2023

The way they fetch data in the redesign looks weird and wasteful. I can't help but feel like it's intentional, especially when you consider the breaking changes to their API that breaks the old/current design. It could be incompetence, but it's been like this ever since this issue was opened.

@33KK
Copy link
Collaborator

33KK commented Sep 4, 2023

It's most likely incompetence, I can't imagine them being stupid and desperate enough to kill their own site just to break the archive

@vednoc
Copy link

vednoc commented Sep 4, 2023

They did make changes that broke Stylus on more than one occasion, so it wouldn't surprise me if it was intentional.

@33KK
Copy link
Collaborator

33KK commented Sep 4, 2023

Did they break their own website and stylish in the process though

@vednoc
Copy link

vednoc commented Sep 5, 2023

Unfortunately, I don't know about the latter because I switched to Stylus pretty early on and never looked back. However, I recall Stylus needed workarounds due to changes on the website. We can draw assumptions from that.

@33KK
Copy link
Collaborator

33KK commented Oct 22, 2023

@tophf pinging here since I don't have email notifications set up on my forgejo instance. I don't really see a way to fix this at the moment, since there doesn't seem to be a way to get style data by id anymore.

@tophf
Copy link

tophf commented Oct 23, 2023

@33KK, IIUC, the new endpoints are /styles/getStyle/ID, /styles/getStyleCustomOptions/ID, /styles/getStyleCss/ID, I've used them in Stylus.

@33KK
Copy link
Collaborator

33KK commented Oct 26, 2023

Oh the new site only works in chromium, that's disgusting, I'll try to get this fixed I guess

@33KK
Copy link
Collaborator

33KK commented Oct 26, 2023

@33KK
Copy link
Collaborator

33KK commented Oct 26, 2023

Uhhh, it kinda did update but incorrectly or something.

EDIT: new styles did appear, but the index is broken or something, I'm not sure

EDIT: ok im stupid

@33KK
Copy link
Collaborator

33KK commented Oct 26, 2023

Okay, this is fixed, the website is still not updated because of jsdelivr cache, but that's a separate issue

@33KK 33KK closed this as completed Oct 26, 2023
@decembre
Copy link
Author

Oh the new site only works in chromium, that's disgusting, I'll try to get this fixed I guess

With Chromium?
I tested by installing Chromium:
The site work (like with Chrome):
I can see my userstyles and open their "page", yes.
But i can't always Login...

@33KK
Copy link
Collaborator

33KK commented Nov 8, 2023

Would you look at that! It's broken again. I wish this website just died already

@33KK 33KK reopened this Nov 8, 2023
@33KK
Copy link
Collaborator

33KK commented Nov 8, 2023

image
What even is this, is this even legal? There's no disagree button, and there's no reason they need access to any information for this to work.

image
image

Color me surprised, this piece of shit sends the EXACT URL including the hash value which isn't even sent to the actual website, and often used for client-side encrypted services. It even base64 encodes it twice, they know that the shit they're doing is shady at best and illegal at worst.

@33KK
Copy link
Collaborator

33KK commented Nov 8, 2023

I just noticed a funny thing, the addon should be banned from AMO even if the spyware is opt-in
image
I reported it on AMO but I doubt they'll do anything.

@tophf
Copy link

tophf commented Nov 8, 2023

getStyleCss made by their site now adds headers calculated by getProtectedHeaders from SALT defined inside the html response for any page of the site.

install made by Stylish uses POST method with Origin: chrome-extension://fjnbnpbmkenffdnngjfgmeleoegfcffe header, so maybe the server checks it now. We don't use this endpoint though.

@33KK
Copy link
Collaborator

33KK commented Nov 8, 2023

https://youtu.be/Mg02NzsXrJk?t=5
image

@33KK
Copy link
Collaborator

33KK commented Nov 9, 2023

Uhh time to finally implement #40 I guess

@33KK
Copy link
Collaborator

33KK commented Nov 9, 2023

I have a feeling that USO might start trimming any special uso-archive syntax from style code when they see its a thing. With just using the already present metadata, the issues are that some people just copied some style from uso-archive and reuploaded it with the old metadata header, and old firefox XUL themes. Parsing the metadata is kinda annoying also

@tophf
Copy link

tophf commented Nov 9, 2023

FWIW, here's our usercss-meta parser, which might be helpful to see the syntax Stylus supports.

@Atexor
Copy link

Atexor commented Nov 11, 2023

Hey, I wanted to migrate my style to userstyles.world since my patience for idiots from userstyles.org has already been exceeded.
I My style is quite popular so I will just put short explanation using CSS content in main Google Page for these users who uses uso/archive.

However, first I wanted to take my style already converted to userCSS on uso archive, I am getting error while clicking "Install with Stylus". As I checked it happens for every other style. I thought error with archive was with fetching new styles due, not current one?

Firefox Stylus here. No errors in console.
obraz

@tophf
Copy link

tophf commented Nov 11, 2023

It's a bug in Stylus, which was recently fixed. Until the new version is released use the style finder in the popup or downgrade to the previous version.

@33KK
Copy link
Collaborator

33KK commented Nov 12, 2023

How cute, those clowns are trying to break it. Surely they are reading this, so yeah, first of all: I hope you can't sleep at night knowing that you're spying on a million of clueless kids that got tricked into clicking on accept; second: if I have to use playwright or puppeteer or whatever, I will :)

@tophf
Copy link

tophf commented Nov 12, 2023

It should be possible to emulate a browser without using playwright/puppeteer. There is no way for a server to ensure the authenticity of a client that doesn't use a server-supplied authorization token.

@33KK
Copy link
Collaborator

33KK commented Nov 12, 2023

That is definitely not necessary for now though, and now the uso-archive updater binary is officially proprietary

@33KK
Copy link
Collaborator

33KK commented Nov 14, 2023

lol the website backend just breaks when you try to use a placeholder inside a setting option, i definitely used that in my styles, and it worked fine. they really did a good job breaking shit 👍

@Atexor
Copy link

Atexor commented Nov 14, 2023

I've finally moved my Google styles 1 2 to userstyles.world :)
Also left warning with link your comment @33KK in both style (will appear on various Google subpages) and on userstyles.org, wait for uso-archive to update it and hope many users will remove Stylish soon.

I have noticed that you also warned people with alert banner on archive. Perhaps maybe you could describe it a little more precisely apart from the link to the screenshot of the add-on's privacy on the Chrome add-ons page and link to Similarweb? The more aware users there are, the faster both Stylish and userstyles will be targeted by the authorities.

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

Well, AMO is ignoring my abuse report, even though I clearly described why it breaks the policy ¯\_ (ツ) _/¯

Their privacy policy on CWS is also incorrect though, should try reporting that too

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

I've finally moved my Google styles 1 2 to userstyles.world :)

The link in the screenshot is broken, and you didn't link to your style, just to userstyles.world homepage on uso

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

Also, if you just copied from uso-archive the dropdown settings are currently broken, trying to figure out a somewhat reliable workaround.

@Atexor
Copy link

Atexor commented Nov 15, 2023

I've finally moved my Google styles 1 2 to userstyles.world :)

The link in the screenshot is broken, and you didn't link to your style, just to userstyles.world homepage on uso

Oh, typo when I first make link it in two lines with bigger font. Userstyles.org cuts the images strangely when you open style site and I had few attempts. Fixed

The main style page was purposeful, the UI you've prepared was nice and it would be easy for the user to use "Search" and choose what they like, but now that I think about it, I actually changed it to a direct link. Thanks.

Also, if you just copied from uso-archive the dropdown settings are currently broken, trying to figure out a somewhat reliable workaround.

I have noticed some issues with it and fixed manually. These appeared for me ~2 years ago in my both styles, so I disabled it (removed placeholders in style to them such like /*[[logostyle]]*/) but left overall option for better times, which didn't come. After adding it back manually and making small adjustments (classes changed over time) it works like a charm.

The bigger problem is that I have still "API.download" error not only on archive, but on userstyles.world. I hope FF version for Stylus will be released soon (Chrome is fine).
@tophf by the way, I noticed that Stylus takes only sites from uso.kkx.one, not userstyles.world - checked for popular styles for Google, YT, FB, Wiki and I didn't finy any. Wouldn't additional integration be a problem?

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

Just reinstall stylus from AMO, worked fine for me. And I do see styles from USW in Stylus popup

@Atexor
Copy link

Atexor commented Nov 15, 2023

Just reinstall stylus from AMO, worked fine for me. And I do see styles from USW in Stylus popup

Interesting, checked for two more styles on FF/Chrome 1 2 and nothing. At the beginning i just thought that my style on uso.world was not yet cached.

I have latest version of Stylus for FF/Chrome (1.5.35/1.538). To be honest why FF version is older?
obraz

@Atexor
Copy link

Atexor commented Nov 15, 2023

Style got cached by uso archive but there is some kind of isssue - style is not working and all of regexpes were deleted. Perhaps it is because I had added more comments right after regex names on sections on Stylus.

USO:
obraz

Style from archive:
obraz

My second style is not updated yet on uso-archive, but as I checked - here comments worked which I had for several sections:
obraz

edit: Just installed temporary stylish (ugh) and installed it via uso - style works here.

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

Well this is what I see in stylish, both code sections are identical
image

@Atexor
Copy link

Atexor commented Nov 15, 2023

I see now... they f*ked something again. On purpose?
I checked for syntax, tried to update style few times and noticed that it loads correctly CSS when I click "update style" otherwise style will be broken. Interesting that it worked for first time. When I deleted style and installed it again it didn't work again. I wouldn't be surprised if this was intentional by uso pseudoadmins.
obraz

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

image
What the fuck is this

@Atexor
Copy link

Atexor commented Nov 15, 2023

I was surprised too when I installed Stylish, it seems that you can't manually install styles without signing up. Spyware as f..k.

If you have still my style installed, try to update it and look if it will work, then delete and install again. Looks that it is against uso-archive and... against themself? Install and update to get style to work?

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

I can't get it to work on stylish either lol

@Atexor
Copy link

Atexor commented Nov 15, 2023

I just removed one character in style to show you ability to update. Check it.

I really wonder what their purpose is in trying to screw up a good website and an add-on like that. Earnings from spying are better than common good? There are more honest ways to make money on an add-on without spyware, ads and destroying site.

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

Earnings from spying are better than common good

While running a website like that is very cheap (unless you have a shitty ruby backed glued together with a shitty javascript backend i guess?), I don't see why a spyware company would run it out of pocket when they could put a ton of ads and spy on their users 🤷

They did an attempt at making a pro subscription, but who would pay that just to get a few mediocre "pro" styles lol. They also tried limiting the amount of styles you can install without pro, that didn't go well, they backed off. I don't think a website like this can be necessarily profitable.

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

Bruh it worked once and I can't replicate it again

@Atexor
Copy link

Atexor commented Nov 15, 2023

It was enough to provide a few advertisements on the website, e.g. more frequent checks for updates in Stylish for "premium" users or the ability to highlight styles on main page by paying a dollar or two.

Well, then I'll think later about how to modify this style so that users get a warning. But knowing life, USO-admins are probably already thinking how to make our lives more difficult and prevent me from doing it.

P.S. I modified first style again to appear "update" button for more tests if you want.

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

OH, I finally noticed whats different between working and broken requests https://youtu.be/Mg02NzsXrJk?t=5
image
image

@33KK
Copy link
Collaborator

33KK commented Nov 15, 2023

Apparently only one of their backend servers is actually functional? 💀

Actually nvm, can't get it to work again, feels like they just deployed an "update" that broke it or something?

@Atexor
Copy link

Atexor commented Nov 15, 2023

@tophf I checked on my notebook, where I have Firefox with Stylus 1.5.35 Stylus too. I didn't obtain API download error, style installed correctly - same browser, same language, same addons.
Could you update Stylus on Firefox to newer version if API version has been resolved on it?

Also, any style from USO.world is unavailable in it's finder too.

@33KK I got comment on my style page on USO.world that someone also has that issue - it would be nice to add ability to answer these reviews under your own theme.
Also, I tested few more times uso style and didn't manage to get it working on this potato site with potato addon. I removed entire style leaving only warning on Search/Translate/Drive about USO bad practices. It looks working, at least for me. Hope that site die soon.

@tophf
Copy link

tophf commented Nov 15, 2023

@Atexor, we unpublished 1.5.37 as it had some bugs. The new version 1.5.38 is still in review. AMO has always been taking a very long time to review the addons, at least the featured ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants