Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor I2C communication interface #392

Open
200km opened this issue Apr 14, 2023 · 2 comments
Open

Refactor I2C communication interface #392

200km opened this issue Apr 14, 2023 · 2 comments
Labels
component component emulation major update incompatible API changes priority::medium priority medium

Comments

@200km
Copy link
Member

200km commented Apr 14, 2023

Overview

Refactor I2C communication interface

Details

Currently, I2C communication interface has many limitations. We need to improve the class for realistic behavior.

  • Register size is limited as 1 byte for 1 address.

Conditions for close

  • I2C is refactored

Supplement

NA

Note

NA

@200km 200km added priority::medium priority medium component component emulation major update incompatible API changes labels Apr 14, 2023
@200km 200km added this to S2E Apr 19, 2023
@200km 200km moved this to Todo in S2E Apr 19, 2023
@200km 200km added this to the Major Update for v7.0.0 milestone May 26, 2023
@200km 200km mentioned this issue Sep 27, 2023
@TomokiMochizuki
Copy link
Member

TomokiMochizuki commented Dec 23, 2024

There is a component that sends multiple commands via i2c in one cycle of c2a.
-> Need to figure out how to store multiple commands to accommodate that component

@200km
Copy link
Member Author

200km commented Dec 23, 2024

ミーティングで話し合った方針

  • I2Cポートにオーバーライド可能な自由度の高いコマンド処理関数を作る
  • コマンドが単純なレジスタアドレスの形式でない場合は、ユーザーでそのコマンド処理関数をオーバーライドして任意の処理が書ける様にする。
  • 上の基本方針をi2c_porti2c_target_communication_with_obc両方をうまく修正することで達成する
  • 具体的な部分はもう少し整理する。 -> @200km
  • 整理できたら、 @TomokiMochizuki@sksat さんにも説明してから実装に入る

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component component emulation major update incompatible API changes priority::medium priority medium
Projects
Status: 🔲 Todo
Development

No branches or pull requests

2 participants