Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a health check for the Extempore TCP server #47

Closed
2 tasks done
oubiwann opened this issue Dec 20, 2020 · 1 comment
Closed
2 tasks done

Create a health check for the Extempore TCP server #47

oubiwann opened this issue Dec 20, 2020 · 1 comment
Labels
Milestone

Comments

@oubiwann
Copy link
Contributor

oubiwann commented Dec 20, 2020

A positive is fairly easy to do: send a blocking message to the server and if a result comes back, you're good. Simply sending a bool like #"#t\r\n" would do it. However, if the server is not okay, you can be in a bad state. A timeout will help with that (see lfex/tcp-client#7). Until then, an async message that writes a warning to a log should be fine.

This could be done with sending a specific bit of data, e.g., #(health ok) which will then be resent by Extempore back to undertone. When that specific packet comes back, it can be intercepted and a lot message can be generated.

Tasks:

  • Create a (check-xt) REPL function, which will async send #(health ok)
  • Create a new pattern check in the TCP message handler for #(health ok), logging that at notice-level
@oubiwann oubiwann added this to the 0.3.0 milestone Dec 20, 2020
oubiwann added a commit that referenced this issue Dec 20, 2020
Addresses initial part of #47.
oubiwann added a commit that referenced this issue Dec 21, 2020
Addresses initial part of #47.
@oubiwann
Copy link
Contributor Author

Done.

oubiwann added a commit that referenced this issue Feb 21, 2021
Addresses initial part of #47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant