Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for disabled reason with utPLSQL v3.1.12 #143

Closed
jgebal opened this issue Feb 7, 2022 · 2 comments · Fixed by #151
Closed

Add support for disabled reason with utPLSQL v3.1.12 #143

jgebal opened this issue Feb 7, 2022 · 2 comments · Fixed by #151
Assignees
@PhilippSalvisberg
Labels
enhancement requires change in utPLSQL Core
Milestone
v1.4.0

Comments

@jgebal
Copy link
Member

jgebal commented Feb 7, 2022 •
edited by PhilippSalvisberg
Loading

With utPSLQL v3.1.12 we will allow users to provide reason when test is disabled.
See PR 1183
The disabled reason should be consumed by IDE and shown in test results window of utPLSQL.
@jgebal
Copy link
Member Author

jgebal commented Feb 7, 2022

There is an issue open in PLSQLDeveloper plugin to address the same.
utPLSQL/utPLSQL-PLSQL-Developer#25

@simasch @PhilippSalvisberg @lwasylow
Let's discuss the details of implementation there.

@PhilippSalvisberg
Copy link
Member

PhilippSalvisberg commented Feb 25, 2022 •
edited
Loading

The ut_realtime_reporter in utPLSQL v3.1.12 does not include the disabled reason. Hence it is currently not possible to show that in the UI. Maybe with v3.1.13.

@PhilippSalvisberg PhilippSalvisberg changed the title Add support for disabled reason with utPLSQL v3.12 Add support for disabled reason with utPLSQL v3.1.12 Feb 25, 2022
@PhilippSalvisberg PhilippSalvisberg mentioned this issue Feb 25, 2022
Closed
@PhilippSalvisberg PhilippSalvisberg self-assigned this Feb 26, 2022
@PhilippSalvisberg PhilippSalvisberg added this to the v1.4.0 milestone Feb 26, 2022
PhilippSalvisberg added a commit that referenced this issue Feb 26, 2022
@PhilippSalvisberg
add reason to disabled annotation in snippets based on #143
b033649
PhilippSalvisberg added a commit that referenced this issue Feb 26, 2022
@PhilippSalvisberg
update test to include disabledReason based on #143
06833c7
PhilippSalvisberg added a commit that referenced this issue Feb 26, 2022
@PhilippSalvisberg
add disabledReason to Test according #143
405972e
PhilippSalvisberg added a commit that referenced this issue Feb 26, 2022
@PhilippSalvisberg
populate disabledReason when reading test from DB #143
78934b1
PhilippSalvisberg added a commit that referenced this issue Feb 26, 2022
@PhilippSalvisberg
show disabledReason in test runner according #143
3ac894e
@PhilippSalvisberg PhilippSalvisberg mentioned this issue Feb 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippSalvisberg PhilippSalvisberg

Labels
enhancement requires change in utPLSQL Core
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Feature/issue 143 - show disabledReason in realtime runner utPLSQL/utPLSQL-SQLDeveloper
2 participants
@jgebal @PhilippSalvisberg