Created SNR vs Wavelength notebook #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
DM1122
requested changes
Aug 25, 2022
|
|
||
| a_i = math.pi * (self.d_i / 2) ** 2 | ||
| a_i = math.pi * (self.image_diameter / 2) ** 2 |
There was a problem hiding this comment.
It looks like this method already exists on line 40. Let's remove this duplicate.
Comment on lines
105
to
108
|
|
||
| # print("n well", self.n_well) | ||
| # print("n bit", self.n_bit) | ||
|
|
There was a problem hiding this comment.
Let's remove unused print statements to keep the code clean.
payload_designer/systems/payloads.py
Outdated
Comment on lines
76
to
77
| """Get the ratio of the light passing through slit to the image of the | ||
| foreoptic.""" |
There was a problem hiding this comment.
Suggestion:
Get the ratio of the light area passing through the slit to the area of the image of the foreoptic.
payload_designer/systems/payloads.py
Outdated
Comment on lines
100
to
113
| # print("wavelength", wavelength) | ||
| # print("ratio", self.get_ratio_cropped_light_through_slit()) | ||
| # print("pixel area", self.sensor.get_pixel_area()) | ||
| # print("f num", self.foreoptic.get_f_number()) | ||
| # print("QE", self.sensor.efficiency(wavelength).decompose() * unit.electron) | ||
| # print("efficiency", self.sensor.efficiency(wavelength)) | ||
| # print("transmittance", self.get_transmittance()) | ||
| # print("area", self.slit.get_area()) | ||
| # print("radiance", radiance(wavelength)) | ||
| # print("sensor dt", self.sensor.dt) | ||
| # print("n bin", self.sensor.n_bin) | ||
| # print("dark noise", self.sensor.get_dark_noise()) | ||
| # print("quantization noise", self.sensor.get_quantization_noise()) | ||
| # print("noise read", self.sensor.noise_read) |
There was a problem hiding this comment.
Let's remove commented code once its no longer needed.
| LOG.info(f"SNR: {snr}") | ||
|
|
||
|
|
||
| def test_get_f_number_units(): |
There was a problem hiding this comment.
Let's add a docstring here for clarity.
DM1122
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.