New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate restructuring of backend Notion service to comply with DI pattern #10

Open

jdtech3 opened this issue Apr 4, 2023 · 0 comments

Contributor

jdtech3 commented Apr 4, 2023 •

edited

Loading

I see, we can revisit this at a later point to find a way to structure this code so it complies with DI without needing to duplicate code. Closing these as resolved

Originally posted by @DM1122 in #9 (comment)

- const _getNotionDB = async function(database_id, notion_client = undefined) {
-  if (notion_client === undefined) notion_client = newNotionClient();

+ const _getNotionDB = async function(database_id, notion_client) {

(server/src/services/notion.service.js)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment