Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add music to game #8

Open
daniyalb opened this issue Nov 27, 2022 · 3 comments · May be fixed by #10
Open

Add music to game #8

daniyalb opened this issue Nov 27, 2022 · 3 comments · May be fixed by #10
Assignees
@nitic04
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@daniyalb
Copy link
Contributor

Add music that plays while the game is running. Music should be copyright free.
@daniyalb daniyalb added the enhancement New feature or request label Nov 27, 2022
@ggggg ggggg added the good first issue Good for newcomers label Nov 27, 2022
@nitic04
Copy link
Contributor

nitic04 commented Nov 18, 2023

For the background music, can it be royalty free? For the music I want to use, the creator just needs to be credited, so I'm thinking of putting a credit in the readme. Is that okay?

@nitic04
Copy link
Contributor

nitic04 commented Nov 18, 2023

Also can someone assign this issue to me please :)

@ggggg
Copy link
Collaborator

ggggg commented Nov 18, 2023

For the background music, can it be royalty free? For the music I want to use, the creator just needs to be credited, so I'm thinking of putting a credit in the readme. Is that okay?

Yes, it has to have a suitable license for us to use. Putting the credits in readme.md is perfect!

@ggggg ggggg linked a pull request Nov 18, 2023 that will close this issue
Added background music #10
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitic04 nitic04

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

8-add-music-to-game utmgdsc/dino-game
Added background music nitic04/dino-game
3 participants
@ggggg @daniyalb @nitic04