Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFlare config is hardcodded in packages.json #8

Open
galaxy4public opened this issue Apr 9, 2020 · 2 comments
Open

CloudFlare config is hardcodded in packages.json #8

galaxy4public opened this issue Apr 9, 2020 · 2 comments

Comments

@galaxy4public
Copy link

I tried to deploy this using yarn run deploy, but it instantly complained that it cannot deploy since it was trying to execute the following command:

cfworker deploy --name utteranc-es --route 'api.utteranc.es/*' src/index.ts

of course this route is not configured in my account since I do not controll that domain.

@zsdycs
Copy link

zsdycs commented May 25, 2021

@galaxy4public

The "--name" and "--route" of "deploy" are customized. If you don't configure them in "CloudFlare", you will naturally get an error.

@galaxy4public
Copy link
Author

@zsdycs , this issue is about the hardcoded line in https://github.com/utterance/utterances-oauth/blob/master/package.json#L9 and is for the future enhancement of the deploy procedure where the end-user can actually modify the arguments without editing the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants