You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Multiple places across VerCors assume that Readable#fileName will be a valid path to an existing path. This is not always true. (for example if an input originates from stdin)
Places I've found so far:
SilverToCol passes the path to the Silver parser and then creates a new RWFile in the origin of AST nodes using the path in Silver's SourcePosition class. In b5e997d I've changed it to use Readable#underlyingPath when that is not None but you can still get crashes if there is no underlyingPath.
SerializeOrigin used fileName instead of underlyingPath (fixed in b5e997d)
Output.scala also uses fileName but it also creates these fileNames itself (so we know there are no folders that can get cut off and this is probably fine)
The text was updated successfully, but these errors were encountered:
Multiple places across VerCors assume that
Readable#fileName
will be a valid path to an existing path. This is not always true. (for example if an input originates from stdin)Places I've found so far:
SilverToCol
passes the path to the Silver parser and then creates a newRWFile
in the origin of AST nodes using the path in Silver'sSourcePosition
class. In b5e997d I've changed it to useReadable#underlyingPath
when that is notNone
but you can still get crashes if there is nounderlyingPath
.SerializeOrigin
usedfileName
instead ofunderlyingPath
(fixed in b5e997d)fileName
but it also creates these fileNames itself (so we know there are no folders that can get cut off and this is probably fine)The text was updated successfully, but these errors were encountered: