Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: frontend needed resolvers/queries #17

Closed
7 tasks done
ShookLyngs opened this issue Jul 29, 2024 · 2 comments · Fixed by #21
Closed
7 tasks done

request: frontend needed resolvers/queries #17

ShookLyngs opened this issue Jul 29, 2024 · 2 comments · Fixed by #21
Assignees

Comments

@ShookLyngs
Copy link
Contributor

ShookLyngs commented Jul 29, 2024

Background

After #14 and #15, there are still requests from the frontend side:

  • Resolvers: fields yet to be implemented
  • Queries: frontend needed queries, new APIs

Resolvers

Bitcoin:

  • transactionsCountIn24Hours

BitcoinTransaction:

  • ckbTransaction: if it's a RGB++ transaction
  • udtInfo: or extraInfo?

use rgbppTransaction field

Ckb:

  • fees: low/average/fast fee rates, may need to be renamed; is this field needed?

CkbAddress:

  • unconfirmedShannon
  • rgbppCellsCount

RgbppStatistic:

  • holdersCount

Queries

  • Query the latest RGB++ L1 transactions
  • Query the latest RGB++ L2 transactions
  • Query a ranking of popular RGB++ assets
@ahonn
Copy link
Collaborator

ahonn commented Jul 29, 2024

I think we need to discuss BitcoinModule RGB++ related fields.

My suggestion is to ensure that the BitcoinModule contains only Bitcoin-related data and that RGB++ related data should be accessed through queries prefixed by rgbpp.
For example, the 'rgbppTransaction' function should support the querying of data by passing in btcTxid or ckbTxHash.

@ShookLyngs
Copy link
Contributor Author

ensure that the BitcoinModule contains only Bitcoin-related data

Currently the following fields are included or planned to be included in non-rgbpp modules:

  • BitcoinAddress
    • rgbppUtxosCount
    • rgbppUtxos
  • CkbAddress
    • rgbppCellsCount
    • rgbppCells
  • BitcoinTransaction
    • ckbTransaction
    • udtInfo (related?)

@ahonn ahonn linked a pull request Jul 30, 2024 that will close this issue
@ahonn ahonn reopened this Jul 30, 2024
@Flouse Flouse closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants