Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.0.28 contains wrong rust MSRV in README.md #7293

Open
ecordonnier-sc opened this issue Feb 10, 2025 · 0 comments
Open

Release 0.0.28 contains wrong rust MSRV in README.md #7293

ecordonnier-sc opened this issue Feb 10, 2025 · 0 comments

Comments

@ecordonnier-sc
Copy link

ecordonnier-sc commented Feb 10, 2025

Hello,
feel free to close and treat it as information only. I noticed this while working on the integration of uutils-coreutils 0.0.28 into Yocto and thought it could be relevant. Maybe some CI job needs to be changed to build with selinux enabled?

Commit 10d3e98 which is between release 0.0.27 and release 0.0.28 updated selinux-sys to a version which requires Rust 1.77, because it uses "offset_of".

0.0.28 fails to compile with 1.70 with selinux enabled:

ecordonnier@lj8k2dq3:~/dev/coreutils$ rustup install 1.70
ecordonnier@lj8k2dq3:~/dev/coreutils$ cargo +1.70 build --features selinux
...
error[E0433]: failed to resolve: could not find `offset_of` in `mem`
    --> /home/ecordonnier/dev/coreutils/target/debug/build/selinux-sys-1def5c504f36bce5/out/selinux-sys.rs:1384:54
     |
1384 |     ["Offset of field: dir_xattr::next"][::std::mem::offset_of!(dir_xattr, next) - 24usize];
     |                                                      ^^^^^^^^^ could not find `offset_of` in `mem`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `selinux-sys` (lib) due to 43 previous errors

0.0.28 actually requires rust 1.77 when selinux is enabled:

$ rustup install 1.77
$ cargo clean
$ cargo +1.77 build --features selinux
warning: /home/ecordonnier/dev/coreutils/src/uu/seq/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
    Finished dev [unoptimized + debuginfo] target(s) in 1.31s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant