Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded Paths in Makefiles #1

Open
xcelina opened this issue Nov 13, 2019 · 0 comments
Open

Hardcoded Paths in Makefiles #1

xcelina opened this issue Nov 13, 2019 · 0 comments

Comments

@xcelina
Copy link

xcelina commented Nov 13, 2019

At least some of the Makefiles in this project hardcode paths to MPI, NCCL, etc. at the lowest directory level, which means a user from a different system has to change those defaults just to be able to build the project. Example: microbenchmark/scale_out_cl/src/Makefile

There are shared.mk files to centralize that and they are used in SOME of the Makefiles, but not in most of them. Please fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant