This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Updated the liftdrag two lines model for the drag component to make it more realistic #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear UUV Sim Devs,
I was playing around with the Lift/Drag models for the fins and I realised one thing:
Concerning the two lines model and the Drag component, it is consistent to use the same "S" shaped graph for both the Lift coefficient CL=f(alpha) and the Drag coefficient CD=f(alpha), as described here. When I refer to "S" shaped graph, I mean the Cl vs alpha graph like presented here.
However, it is not physically correct to have a drag vector oriented towards the inertial velocity of the sub when the alpha is negative: it should always be oriented opposite to the inertial velocity (as shown here) whatever the alpha value.
Therefore I have updated the code to generate a "V" shaped two lines approximation for the drag component (as shown here, CD vs alpha).
Best regards,
Achille MARTIN