You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Create a justification for an EOC (eg. select EOC 1.1)
Press Save
Edit that EOC justification (eg. EOC 1.1)
Uncheck the checkbox for EOC 1.1
Save
What will happen is that in handleSave, matchIndex=-1 (for a reason that I am unsure of). This means that, it is inserting a "new" entry in the database.
Another weird behaviour that I've seen from the Redux log is that EVALUATION_PATCH_PENDING is removing an array element.
I am not exactly sure what the problem is.
tldr; Cannot deselect the last EOC item
The text was updated successfully, but these errors were encountered:
It might sound like a cop-out but we could just prevent users from deselecting the checkbox for the eoc their currently viewing.
E.g. If you're editing EOC 1.1 you can't deselect EOC 1.1 from the list.
Checkout branch i51-eoc-deselect-bug where I have implemented this (haven't solved the underlying issue though).
@MouseAndKeyboard i think thats fine, but have a think about the dynamics. What if I said put the justification in EOC 1.1... then later I have a justification for EOC 1.2 and 1.3... but now... what If later on I decided that my justification on EOC 1.2 and 1.3 should also include 1.1... how would I do that then?
Steps to reproduce:
What will happen is that in
handleSave
,matchIndex=-1
(for a reason that I am unsure of). This means that, it is inserting a "new" entry in the database.Another weird behaviour that I've seen from the Redux log is that
EVALUATION_PATCH_PENDING
is removing an array element.I am not exactly sure what the problem is.
tldr; Cannot deselect the last EOC item
The text was updated successfully, but these errors were encountered: