Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address repeated code #57

Open
2 tasks
frinzekt opened this issue Jan 25, 2021 · 0 comments
Open
2 tasks

Address repeated code #57

frinzekt opened this issue Jan 25, 2021 · 0 comments
Labels
client client related issue

Comments

@frinzekt
Copy link
Member

Due to the time and priorities of stage 1, there has been some code that has been copy pasted over.

Some of them are:

  • CustomFormField (inspired from the Living Lab custom field)
  • EOCAccordion there are two of them at the moment. One of them is for the coordinator, and the other is for the reviewer. There needs to be a discussion on this, because fundamentally they use different states, but they use two of the same concept, namely 1. EOCCards and 2. the logic to create EOC to accordions

Additionaly:

  • code that has "TODO"
@frinzekt frinzekt added the client client related issue label Jan 25, 2021
@frinzekt frinzekt mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client client related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frinzekt