Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way how the Custom Tab works in the Coordinator Page #70

Open
frinzekt opened this issue Jan 26, 2021 · 0 comments
Open

Change the way how the Custom Tab works in the Coordinator Page #70

frinzekt opened this issue Jan 26, 2021 · 0 comments
Labels
client client related issue enhancement New feature or request

Comments

@frinzekt
Copy link
Member

Currently the way how it works is that the custom tab is a component that conditionally exposes component. The problem with this is that it makes it very hard to navigate around the coordinator pages using links.

An example that makes it hard has arised from #64, wherein once a coordinator wants to go back, the link to go back is always the index, when ideally the coordinator should be taken to the review coordinator page.

What work needs to be done:

  • modification of the custom tab
  • custom hook (for loading data in the different pages). This should be similar to how the reviewer pages are done, wherein the custom hooks checks if the currently being viewed is updated by checking the courseID in the state and the URL. Calling only the server if the courseID is different or null
@frinzekt frinzekt added enhancement New feature or request client client related issue labels Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client related issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant