Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdowns accessibility updates #149

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Dropdowns accessibility updates #149

merged 4 commits into from
Jun 25, 2020

Conversation

lcaple
Copy link
Contributor

@lcaple lcaple commented Jun 25, 2020

resolves #137

  • Removes open menu functionality from top level link in white bar when using the keyboard
  • Pressing space or enter on top level in white bar now opens the top level link
  • Added a button to top level menu to take keyboard focus and allow expansion of the dropdown menu
  • Added visual focus indicator to button in white bar
  • Escape now closes any open menu regardless of how it's opened
  • Aria labels adjusted to properly indicate when a menu is opened

@lcaple
Copy link
Contributor Author

lcaple commented Jun 25, 2020

I need to come back and add the following:

  • Toggle any/all open menus when another menu opens
  • Fine-tune the above behavior between the mouse and the enter button

@lcaple lcaple merged commit 8b4f29e into master Jun 25, 2020
@lcaple lcaple deleted the dropdowns-accessibility-updates branch May 11, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit accessibility of main nav menu
1 participant
@lcaple