Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment entry field affected by commit message inspections #418

Open
leoluk opened this issue Jul 13, 2021 · 0 comments
Open

Comment entry field affected by commit message inspections #418

leoluk opened this issue Jul 13, 2021 · 0 comments
Labels

Comments

@leoluk
Copy link

leoluk commented Jul 13, 2021

The Gerrit plugin's code review comment entry box is affected by these commit message settings:

image

In particular, the "wrap when typing reaches the right margin" option interacts badly with review comments which are meant to be soft-wrapped by the Gerrit UI, rather than hard-wrapped by the author.

Perhaps it would be better to use a generic text area here vs. reusing the commit one?

@uwolfer uwolfer added the bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants