Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing draft comments without adding a patchset #452

Open
youngkih opened this issue Jul 22, 2022 · 3 comments
Open

Publishing draft comments without adding a patchset #452

youngkih opened this issue Jul 22, 2022 · 3 comments

Comments

@youngkih
Copy link

Hello team! Quick newbie question :)

I'm trying to figure out how to reply to existing comment without adding a patchset.
I found how to publish a draft comment, but what I'd like to do is to 'send' that draft comment so that the reviewers can view them as well.

From the web GUI, we can do it like below button, by clicking on 'SEND' button,
스크린샷 2022-07-22 오전 9 37 54

which seems to send POST /review to the current revision.
스크린샷 2022-07-22 오전 9 38 12

Can anyone help explain if this functionality is provided by this plugin? If so, would appreciate for help.

Thank you in advance!

@uwolfer
Copy link
Owner

uwolfer commented Jul 22, 2022

You can write a comment, and then publish it by using the "Code-review" action with value 0 if you do not want to give any votes (it sets the code review to 0, but you can use any other available numbers). Please re-open this issue if this does not answer your question.

@uwolfer uwolfer closed this as completed Jul 22, 2022
@youngkih
Copy link
Author

Hello @uwolfer , thank you for the answer, but seems like the Code-review action is only available to the reviews that are incoming. What I'm looking for is to add comments on the PR I'm creating. Would this be possible?
스크린샷 2022-07-22 오후 2 46 30

@uwolfer
Copy link
Owner

uwolfer commented Jul 22, 2022

Thanks for your explanation. I think this is specific to your setup where you are not allowed to do update "review" status of your own changes. In my setup, I'm able to use these actions. How does the web UI work in this case? Can you just send comment, but not set any votes?

@uwolfer uwolfer reopened this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants