Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting discretization for Eurus #8

Open
bsmithyman opened this issue Nov 17, 2015 · 6 comments
Open

Correcting discretization for Eurus #8

bsmithyman opened this issue Nov 17, 2015 · 6 comments
Assignees
Labels

Comments

@bsmithyman
Copy link
Member

Issue created to discuss Eurus testing & corrections.

@bsmithyman
Copy link
Member Author

At #7, @ShaunHadden said:

I've made the change to the 'Dz' calculation that was wrong on the timedomain branch for eurus.py. This still needs more work so perhaps we should wait to merge it into master?

@ShaunHadden
Copy link
Member

Sorry!

@ShaunHadden
Copy link
Member

I am currently going through the paper Gerhard sent us and comparing it to our discretization to see if I can spot the error that's causing the amplitudes to be unstable

@bsmithyman
Copy link
Member Author

So yeah, I think that the change on the Dz term in the stencil could probably be merged in now. It's a bugfix anyway, so it's not like it's going to break anything outside Eurus. However, if it's hard to separate it from the other commits we can wait, I guess. Is it amenable to being cherry-picked? I seem to recall that there are a number of other changes to different files on that branch, and I think we're going to need a more complex merge.

@bsmithyman
Copy link
Member Author

Sorry!
No worries :)

Okay, good. Why don't you work on that, and then think about a good way to make an atomic change vs. master (i.e., don't drag in all the other stuff from the timedomain branch yet).

@bsmithyman bsmithyman added the bug label Nov 17, 2015
@ShaunHadden
Copy link
Member

feel free to just 'cherrypick' the one change, I don't think anything else is required just yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants