From 256eef3ebea1b7382b6e348663cb54ed26ff21c7 Mon Sep 17 00:00:00 2001 From: "Palicki, Stefan" Date: Thu, 10 Apr 2025 13:39:53 -0700 Subject: [PATCH] common: fixes for coverity major & moderate issues --- src/common/ittnotify.cpp | 4 ++-- src/common/logging.cpp | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/common/ittnotify.cpp b/src/common/ittnotify.cpp index 9da5765568a..a8a409fb20d 100644 --- a/src/common/ittnotify.cpp +++ b/src/common/ittnotify.cpp @@ -87,9 +87,9 @@ void primitive_task_start(primitive_kind_t kind) { if (kind_idx < primitive_kind::internal_only_start) { assert((size_t)kind_idx < sizeof(prim_kind_itt_strings) / sizeof(prim_kind_itt_strings[0])); + __itt_task_begin(itt_domain(), __itt_null, __itt_null, + prim_kind_itt_strings[kind_idx]); } - __itt_task_begin(itt_domain(), __itt_null, __itt_null, - prim_kind_itt_strings[kind_idx]); thread_primitive_kind = kind; } diff --git a/src/common/logging.cpp b/src/common/logging.cpp index bb4f1f9b2a8..c4881345052 100644 --- a/src/common/logging.cpp +++ b/src/common/logging.cpp @@ -17,6 +17,7 @@ #include "common/logging.hpp" #include "common/utils.hpp" +#define SPDLOG_DISABLE_DEFAULT_LOGGER #include "spdlog/sinks/rotating_file_sink.h" #include "spdlog/spdlog.h" @@ -54,9 +55,12 @@ log_manager_t::log_manager_t() "logger enabled,logfile::{},size::{},num_logfiles::{}", logfile_path_, logfile_size_, num_logfiles_); dnnl_logger->info(SEPARATOR_STR); - } catch (spdlog::spdlog_ex &exception) { + } catch (const spdlog::spdlog_ex &exception) { printf("onednn_verbose,info,exception while creating logfile: %s\n", exception.what()); + } catch (const std::exception &exception) { + printf("onednn_verbose,info,standard library exception caught: %s\n", + exception.what()); } }