Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert usage in device code with DPC++ #1972

Open
MikeDvorskiy opened this issue Dec 18, 2024 · 0 comments
Open

Assert usage in device code with DPC++ #1972

MikeDvorskiy opened this issue Dec 18, 2024 · 0 comments

Comments

@MikeDvorskiy
Copy link
Contributor 

          Based on [1933](https://github.com/oneapi-src/oneDPL/pull/1933#discussion_r1873731880) discussion,  I agree with following conclusion:

We should consider the use of assert in device code as an extension of DPC++ and possibly other SYCL implementations, so it should be guarded by some macros

I don't insist doing it in this PR but I will create an GitHub issue.

Originally posted by @MikeDvorskiy in #1970 (comment)
@MikeDvorskiy MikeDvorskiy mentioned this issue Dec 18, 2024
Merged
@dmitriy-sobolev dmitriy-sobolev changed the title Based on [1933](https://github.com/oneapi-src/oneDPL/pull/1933#discussion_r1873731880) discussion, I agree with following conclusion: Assert usage in device code with DPC++ Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MikeDvorskiy