-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] remove convert_to_supported function #2217
Open
icfaust
wants to merge
53
commits into
uxlfoundation:main
Choose a base branch
from
icfaust:dev/remove_convert_to_supported
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Enhancement] remove convert_to_supported function #2217
icfaust
wants to merge
53
commits into
uxlfoundation:main
from
icfaust:dev/remove_convert_to_supported
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/intelci: run |
/intelci: run |
/intelci: run |
/intelci: run |
icfaust
requested review from
samir-nasibli,
ethanglaser,
Alexsandruss and
ahuber21
as code owners
December 11, 2024 11:00
/intelci: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the array_api rollout, moving the capability of convert_to_supported in the table creation is desired. As checking for datatypes for oneDAL should occur on the tables, and not on the arrays before they become tables. When they become tables, they can be converted to the supported type via the queue supplied to them. This logic only currently occurs with numpy arrays, as sycl_usm_ndarrays are not allowed in _device_offload.dispatch to be moved off their current device (i.e. when queue devices don't match, an error is thrown). Given they are on their current device, they are already in a supported format. Dlpack will be handled separately in its own PR.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance