Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2281 reduce bulk send #464

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Feature/2281 reduce bulk send #464

merged 4 commits into from
Dec 18, 2024

Conversation

mabiede
Copy link
Contributor

@mabiede mabiede commented Nov 27, 2024

  • don't create a bulk sent event when the provided list is empty
  • in case is empty list, directly return unit
  • use newly added Pool_event.map when lists are converted to events

@mabiede mabiede requested a review from timohuber November 27, 2024 08:06
@mabiede mabiede self-assigned this Nov 27, 2024
timohuber
timohuber requested changes Dec 3, 2024
View reviewed changes
@mabiede mabiede force-pushed the feature/2281-reduce-bulk-send branch from ca77398 to c54e634 Compare December 16, 2024 10:06
@mabiede mabiede requested a review from timohuber December 16, 2024 10:08
@timohuber timohuber merged commit afed656 into main Dec 18, 2024
5 checks passed
@timohuber timohuber deleted the feature/2281-reduce-bulk-send branch December 18, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timohuber timohuber timohuber approved these changes

Assignees

@mabiede mabiede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabiede @timohuber