Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions on container tags #2477

Closed
Qusic opened this issue Apr 25, 2023 · 5 comments · Fixed by #2757
Closed

Suggestions on container tags #2477

Qusic opened this issue Apr 25, 2023 · 5 comments · Fixed by #2757
Labels
enhancement New feature or request Stale

Comments

@Qusic
Copy link
Contributor

Qusic commented Apr 25, 2023

Current container tags are hard to use and don't follow the convention of common images.
https://github.com/v2fly/v2ray-core/pkgs/container/v2ray/versions?filters%5Bversion_type%5D=tagged

A few suggestions on container tags:

  1. please remove arch from the tag and build multi-arch images
  2. add some non-fixed tags such as latest, v5, v4 to track the latest version or a range of versions

Thanks!

@AkinoKaede
Copy link
Contributor

c.c. @xiaokangwang

@AkinoKaede AkinoKaede added the enhancement New feature or request label Apr 26, 2023
@xiaokangwang
Copy link
Contributor

Currently the container building pipeline don't support multi-arch images, and a separate step would be necessary to get it working. Pull request on this is welcomed, so long as it don't modify exist building steps.

Tags such as latest will be considered once multi-arch tags are available.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Sep 1, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
@AkinoKaede AkinoKaede removed the Stale label Sep 7, 2023
@AkinoKaede AkinoKaede reopened this Sep 7, 2023
@Qusic
Copy link
Contributor Author

Qusic commented Nov 12, 2023

redhat-actions/buildah-build#121 (comment)
seems quite tedious. to keep most of current pipeline implementation intact, another job outside of the strategy matrix is required to merge manifests and push them all together.
or do you mind that we simply remove the strategy matrix and use one single script step to build all archs in one shot. this way the pipeline can be simpler but we will have to invoke podman commands manually instead of using existing actions

Copy link
Contributor

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants