From f7bdc2ef7453a9d925a7bdb5c5e32b5d347d5a92 Mon Sep 17 00:00:00 2001
From: Igor Sheludko <isheludko@gmail.com>
Date: Tue, 19 Nov 2024 17:20:24 +0100
Subject: [PATCH] Update tests expectations that check stack traces. (#205)

V8 has changed how Function.blah entries look like in stack traces
(see https://crrev.com/c/5907815). This CL updates tests expectations
according to new behavior and re-enables the affected tests.
---
 test/message/assert_throws_stack.out  | 2 +-
 test/message/internal_assert_fail.out | 2 +-
 test/message/message.status           | 4 ----
 test/parallel/parallel.status         | 3 ---
 test/parallel/test-fs-promises.js     | 2 +-
 5 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/test/message/assert_throws_stack.out b/test/message/assert_throws_stack.out
index b1f3ea2108ba9c..897ddf36a04eb0 100644
--- a/test/message/assert_throws_stack.out
+++ b/test/message/assert_throws_stack.out
@@ -23,7 +23,7 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
   actual: Error: foo
       at assert.throws.bar (*assert_throws_stack.js:*)
       at getActual (node:assert:*)
-      at Function.throws (node:assert:*)
+      at strict.throws (node:assert:*)
       at Object.<anonymous> (*assert_throws_stack.js:*:*)
       at *
       at *
diff --git a/test/message/internal_assert_fail.out b/test/message/internal_assert_fail.out
index 9fc86673262dba..5f1026791f323d 100644
--- a/test/message/internal_assert_fail.out
+++ b/test/message/internal_assert_fail.out
@@ -6,7 +6,7 @@ Error [ERR_INTERNAL_ASSERTION]: Unreachable!
 This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
 Please open an issue with this stack trace at https://github.com/nodejs/node/issues
 
-    at Function.fail (node:internal/assert:*:*)
+    at assert.fail (node:internal/assert:*:*)
     at * (*test*message*internal_assert_fail.js:7:8)
     at *
     at *
diff --git a/test/message/message.status b/test/message/message.status
index c85f477896e465..aa1e23879edd63 100644
--- a/test/message/message.status
+++ b/test/message/message.status
@@ -33,10 +33,6 @@ vm_display_syntax_error.js: SKIP
 vm_dont_display_runtime_error.js: SKIP
 vm_dont_display_syntax_error.js: SKIP
 
-# Temporarily skip for https://crrev.com/c/5907815
-assert_throws_stack.js: SKIP
-internal_assert_fail.js: SKIP
-
 [$system==win32]
 
 [$system==linux]
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
index 407ad00f88cf55..926258e4a67aac 100644
--- a/test/parallel/parallel.status
+++ b/test/parallel/parallel.status
@@ -70,9 +70,6 @@ test-v8-serdes: SKIP
 
 test-v8-stats: SKIP
 
-# Temporarily skip for https://crrev.com/c/5907815
-test-fs-promises: SKIP
-
 test-strace-openat-openssl: SKIP
 test-policy-dependency-conditions: SKIP
 
diff --git a/test/parallel/test-fs-promises.js b/test/parallel/test-fs-promises.js
index d28af0f4833c49..796ad3224c4dba 100644
--- a/test/parallel/test-fs-promises.js
+++ b/test/parallel/test-fs-promises.js
@@ -58,7 +58,7 @@ assert.strictEqual(
       code: 'ENOENT',
       name: 'Error',
       message: /^ENOENT: no such file or directory, access/,
-      stack: /at async Function\.rejects/
+      stack: /at async ok\.rejects/
     }
   ).then(common.mustCall());