Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged: src: remove ArrayBufferAllocator::Reallocate override #190

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

syg
Copy link

@syg syg commented Jun 21, 2024

It's being deprecated and removed in V8.

PR-URL: nodejs#52910
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@syg syg requested review from ajklein and isheludko June 21, 2024 00:01
Copy link
Member

@ajklein ajklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@syg syg merged commit cce9437 into v8:node-ci-2024-06-03 Jun 21, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants