Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in test data, some people have certain secret units that are not possible given their level #225

Open
jatloe opened this issue Jul 27, 2023 · 1 comment
Labels

Comments

@jatloe
Copy link
Contributor

jatloe commented Jul 27, 2023

For example, "Adriana Gardner (Year 2)" is level 9 but has Forest of Wandering and Collinia Colosseum

@jatloe jatloe added the bug label Jul 27, 2023
@vEnhance
Copy link
Owner

there isn't any validation on secret units only being given to people with high enough level, only in the logic for unlocking the units to begin with. given the extra complexity it would take to implement that check i don't want to.

i guess one could try to configure the random test data generator to avoid this situation but that seems super annoying and not necessarily worth the effort, but if someone does so i'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants