Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow edits to previous years unit submissions #318

Open
anterick-cjx opened this issue Oct 22, 2023 · 2 comments
Open

Allow edits to previous years unit submissions #318

anterick-cjx opened this issue Oct 22, 2023 · 2 comments
Labels

Comments

@anterick-cjx
Copy link

Basically I tried to "submit additional problems" for last year's unit since otherwise I'd have to request it again and that takes too long, but it says you can't do that because the semester isn't active. I think it'd be a lot more efficient if we were allowed to submit from previous years or something like that.

@Incompleteusern
Copy link
Contributor

I think the consensus is that #300 is the easiest way of implementing this.

@vEnhance
Copy link
Owner

I agree that finishing #300 (i.e. allowing automatic approval of requests of units that were unlocked in a previous year) would provide a workaround here that isn't too annoying.

It's more complicated to try and resubmit to an inactive semester, because the pset/unit logic is based on ordered pairs of (human, year) rather than just the human. So, e.g. if a student submits a unit in year Y and then resubmits it in year Y+1 it's no longer clear which year that submission should be attached to.

In the long term maybe we should just drop the year dependence; 1ebab2a6 was a related issue caused by the extra dependence. However, that's quite long-term because it requires refactoring a ton of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants