Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using named tuples #22

Closed
pradyunsg opened this issue Nov 6, 2015 · 6 comments · May be fixed by #31
Closed

Using named tuples #22

pradyunsg opened this issue Nov 6, 2015 · 6 comments · May be fixed by #31

Comments

@pradyunsg
Copy link

Currently, All attributes and methods of Color return tuples or strings. It should be relatively simple to return namedtuples instead of simple tuples.

Why?
Namedtuple makes your tuples _self-document. You can easily understand what is going on by having a quick glance at your code._1
@pradyunsg
Copy link
Author

Bump.

@vaab
Copy link
Owner

vaab commented Jun 21, 2016

This is an excellent suggestion. Sorry for the late answer, this got lost and stuck between my actual intention to release other stuff containing already this part. Although, if any PR would pop in and that it pass the basic requirements, I'll accept it with pleasure.

Sorry again for this overly late answer anyway.

@pradyunsg
Copy link
Author

Great. If and when I get the time to do this, I'll shoot a PR.

@pradyunsg
Copy link
Author

If someone else is interested in doing this, please do.

vaab added a commit that referenced this issue Apr 19, 2017
@vaab
new: use namedtuple for rgb and hsl tuples. (fixes #22)
46b9846
@vaab vaab mentioned this issue Apr 19, 2017
Open
vaab added a commit that referenced this issue May 5, 2017
@vaab
new: use namedtuple for rgb and hsl tuples. (fixes #22)
d8c2e26
@sayeghr
Copy link
Contributor

sayeghr commented Oct 28, 2017

Hi @vaab, should this issue be considered closed?

@pradyunsg
Copy link
Author

Closing since it looks like it got solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consequent refactor for format and converters independance vaab/colour
3 participants
@vaab @pradyunsg @sayeghr