You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The idea comes from a forum question, asking for the possibility of setting maxPageSize limit for handling cases such as forged requests for either no page size or a very big one.
Describe the solution you'd like
Support for this could be added by giving control to the users for setting maxPageSize either through already existing properties (being compatible with spring-data-jpa standards makes it easier to integrate Hilla in already existing projects):
or by enabling the users to define a default page bean which can be taken into account by the framework, if present.
It would be desirable to support the already existing / standard ways to support this in Vaadin, unless some specific need prevents us from using them.
Describe alternatives you've considered
Creating a couple of CRUD super classes in the user workspace that set the limits by overriding the defaults in CrudRepositoryService and etc. when defining a BrowserCallable service.
Additional context
No response
The text was updated successfully, but these errors were encountered:
Some of the CRUD related classes are moved to flow/vaadin-spring repo, so there might be some extra efforts needed when adding the support for this enhancement.
Another consideration is the current implementation of CrudRepositoryService in Flow is slightly different from what we have in Hilla, where it doesn't provide a default constructor, and that means the user code should always define their CRUD services by implementing the constructor that accepts the repository, while in Hilla, you don't need any constructors. That's a breaking change for Hilla users.
Describe your motivation
The idea comes from a forum question, asking for the possibility of setting
maxPageSize
limit for handling cases such as forged requests for either no page size or a very big one.Describe the solution you'd like
Support for this could be added by giving control to the users for setting
maxPageSize
either through already existing properties (being compatible with spring-data-jpa standards makes it easier to integrate Hilla in already existing projects):or by enabling the users to define a default page bean which can be taken into account by the framework, if present.
It would be desirable to support the already existing / standard ways to support this in Vaadin, unless some specific need prevents us from using them.
Describe alternatives you've considered
Creating a couple of CRUD super classes in the user workspace that set the limits by overriding the defaults in
CrudRepositoryService
and etc. when defining a BrowserCallable service.Additional context
No response
The text was updated successfully, but these errors were encountered: