-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FormLayout with CSS Grid #8583
Comments
Here are some findings that we made with @DiegoCardoso during the implemetation:
|
|
Just asking: Did you consider creating |
Yes, it was considered, but
We're aware that there are apps out there that do weird things with the current FormLayout that the refactored model may break, but it feels like a slipper slope to avoid changing internal implementation details to avoid breaking custom hacks – we could hardly make any changes if we always tried to avoid that. If there's a lot of backlash about the changes in 24.7, it's also possible to reintroduce the flexbox-based model in the same component without too much hassle, as it would only be used for |
Implement current FormLayout component's behaviour using CSS grid while maintaining backward compatibility.
refactor!:
Follow the AC defined: vaadin/platform#7172
The text was updated successfully, but these errors were encountered: