-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Card slots #8233
Open
jouni
wants to merge
30
commits into
main
Choose a base branch
from
card-proto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[feat] Card slots #8233
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a63e7e6
vertical orientation works alright, horizontal has issues
jouni 09c71c8
remove commented code
jouni 2898c52
Update card.html
jouni e92f5dd
Update card.html
jouni 34afedc
keep media as the first child
jouni 8edd4e3
experiment with custom properties (no horizontal version)
jouni 4d3f26a
robust prototype with slots and shadow parts
jouni 899fa65
Merge branch 'main' into card-proto
jouni 789bf99
improve dev playground
jouni ae35afe
switch cover-media <-> stretch-media variant names
jouni 54ef765
fix material theme
jouni 7cc9f34
fix: run mutation observer once when connected
jouni e986226
fix a couple of sonarcloud issues
jouni 6561311
update visual test for Lumo
jouni d64f975
remove duplicate visual test
jouni 559d68a
update visual test for Material
jouni 14c0248
use Lumo-specific component imports in Lumo tests
jouni a56433e
fix CSS lint error
jouni ca48b34
remove TODOs
jouni 596edd5
First draft of JSDoc
jouni ba98bec
prefix internal custom props with underscore
jouni 1ac1a93
refactor: use slotchange listener instead of MutationObserver
jouni b603031
test: update screenshots
web-padawan 36a1cc7
test: import badge-global in card visual test
web-padawan e9bad8b
test: remove Lumo custom CSS properties from Material test
web-padawan 972e502
test: cleanup card visual test, use local image (#8369)
web-padawan 73a11a4
fix: restore styles for hidden attribute
web-padawan 9a7c9dc
docs: add protected JSDoc annotations
web-padawan dc8d1d2
refactor: add box-sizing border-box to card styles
web-padawan 50e0fa0
test: update visual test screenshots
web-padawan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+580 Bytes
(100%)
...ard/test/visual/lumo/screenshots/card/baseline/theme-horizontal-media-cover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+302 Bytes
(100%)
...d/test/visual/lumo/screenshots/card/baseline/theme-horizontal-media-stretch.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-158 Bytes
(100%)
packages/card/test/visual/lumo/screenshots/card/baseline/theme-horizontal.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-360 Bytes
(96%)
...ages/card/test/visual/lumo/screenshots/card/baseline/theme-media-cover-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.65 KB
(88%)
...ges/card/test/visual/lumo/screenshots/card/baseline/theme-media-cover-image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.91 KB
(86%)
packages/card/test/visual/lumo/screenshots/card/baseline/theme-media-stretch.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+370 Bytes
(100%)
...test/visual/material/screenshots/card/baseline/theme-horizontal-media-cover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.03 KB
(100%)
...st/visual/material/screenshots/card/baseline/theme-horizontal-media-stretch.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-103 Bytes
(100%)
packages/card/test/visual/material/screenshots/card/baseline/theme-horizontal.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-436 Bytes
(96%)
.../card/test/visual/material/screenshots/card/baseline/theme-media-cover-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.39 KB
(88%)
...card/test/visual/material/screenshots/card/baseline/theme-media-cover-image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.7 KB
(86%)
...ges/card/test/visual/material/screenshots/card/baseline/theme-media-stretch.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rounded right side corners of the image look kinda off in this material version, or?
The same goes for another image below.. or is this intended in material design? The lumo versions looks way better in this regard 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks. Yes, we need to fix the Material version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in latest Chrome and it seems to look correctly, maybe it's related to outdated Chrome version used by Material tests as it differs from Lumo setup (some CSS properties could be not supported yet in Chrome 88).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPD: my assumption above was correct. Created #8383 to update Chrome version.
.