-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pin ubuntu version in GitHub Actions #8375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
force-pushed
the
test/fix-ubuntu-version-in-ci
branch
from
December 20, 2024 05:52
0974f74
to
869c676
Compare
Failed CI run can be seen here: #8374 |
sissbruecker
force-pushed
the
test/fix-ubuntu-version-in-ci
branch
from
December 20, 2024 06:20
869c676
to
291cb6c
Compare
Quality Gate passedIssues Measures |
sissbruecker
commented
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the version for all jobs, even if they don't use Puppeteer / Playwright. Seems confusing otherwise?
web-padawan
approved these changes
Dec 20, 2024
web-padawan
changed the title
test: pin ubuntu version in CI
chore: pin ubuntu version in GitHub Actions
Dec 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
sissbruecker
added a commit
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
web-padawan
pushed a commit
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubuntu-latest
now refers toubuntu-24.04
, which results in the following issues:Package libicu70 is not available, but is referred to by another package
For the App Armor issue we could do what the Puppeteer team did, and disable App Armor for CI runs (puppeteer/puppeteer#13196). However that doesn't solve the Playwright installation issue. For now it seems easiest to pin the Ubuntu version to the one we used before and wait for things to settle.