fix: ensure error message is announced by VoiceOver #8384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
fix/ensure-error-message-announced
branch
from
591c4ab to
b64984f
Compare
|
web-padawan
approved these changes
Dec 23, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
web-padawan
pushed a commit
that referenced
this pull request
Dec 23, 2024
Co-authored-by: Sergey Vinogradov <[email protected]>
web-padawan
pushed a commit
that referenced
this pull request
Dec 23, 2024
Co-authored-by: Sergey Vinogradov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the issue where VoiceOver didn't announce the error message when returning focus to the field from another element in Safari. The issue is fixed by removing the
alertrole from the error message element and instead using a separate element witharia-live="assertive"for the announcement. The assertive mode ensures the error message is correctly announced on value commit with Enter to match the previous behavior.Fixes #8349
Type of change