-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize US market holidays' days of mourning entries #2203
Comments
IMO relying on presidential library official naming which is itself managed by the National Archives and Records Administration (NARA) might be for the best here. Interestingly, the Jimmy Carter ones went with his nickname instead of his actual first name. |
I found this one -- https://guides.loc.gov/presidents-portraits/chronological @PPsyrius could you add some more URLs? |
@arkid15r I'm going by the Presidents who appear in this holiday list first:
|
I see, I thought there was a single source of truth for those names. Richard M. Nixon is the only discrepancy I found for this list vs the link a posted above. What do you guys think of using Library of Congress source for standardizing this? |
@arkid15r Fine by me, although I'm somewhat surprised NARA and LoC haven't agreed to standardize Nixon's name references lol Anyway, it seems that both the White House and USN websites use |
Based on #2201 we need to come up with a standardized naming for this type of cases.
It looks like they have to start with "National Day of Mourning" and include a custom text to add more context.
I also think it should include "former President" part.
And we need to decide on the name format (yeah, naming is hard):
The text was updated successfully, but these errors were encountered: