-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graceful shutdown process reported as error in logs. #1007
Comments
@cheatfate I don't think I follow what you meant. The links you sent don't match with what you mention (I believe). There is a One of them points to this piece of code in the same function as the aforementioned except HttpError as exc:
debug "Http Error", exc = exc.msg
except AsyncStreamError as exc: And the other points to the parameters of the next function, which seems to be unrelated to any hostname: string,
address: MultiAddress,
peerId: Opt[PeerId] = Opt.none(PeerId)): Future[Connection] {.async.} = Do you mean that the "normal shutdown process" somehow triggers the |
Everything what falls into
looks like serious error, and |
Please, next time it'd be great to have what the expected behavior should be when describing the issue. |
@cheatfate do you have more logs related to it? The error msg "Transport closed, no more connections!" is created by
nim-libp2p/libp2p/transports/tcptransport.nim Line 204 in 9059a8a
Was there a log "Server was closed" before the one you reported? If it was indeed caused by nim-libp2p/libp2p/transports/tcptransport.nim Line 234 in 9059a8a
|
This error statement has been shown on normal shutdown process:
It happens because of this handler https://github.com/status-im/nim-libp2p/blob/e3c967ad1939fb33b8e13759037d193734acd202/libp2p/switch.nim#L276 which do not knows anything about
TransportUseClosedError
which can be raised https://github.com/status-im/nim-libp2p/blob/unstable/libp2p/transports/tcptransport.nim#L247-L249 and https://github.com/status-im/nim-libp2p/blob/unstable/libp2p/transports/wstransport.nim#L283-L285The text was updated successfully, but these errors were encountered: