Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily jobs report success even when workflows failed #1197

Closed
diegomrsantos opened this issue Sep 19, 2024 · 0 comments · Fixed by #1200
Closed

Daily jobs report success even when workflows failed #1197

diegomrsantos opened this issue Sep 19, 2024 · 0 comments · Fixed by #1200
Assignees
@AlejandroCabeza

Comments

@diegomrsantos
Copy link
Contributor

diegomrsantos commented Sep 19, 2024 •
edited
Loading

One example https://github.com/vacp2p/nim-libp2p/actions/runs/10935762205. Jobs must report failure when there are failed jobs.
@AlejandroCabeza AlejandroCabeza mentioned this issue Sep 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2024
@AlejandroCabeza @diegomrsantos
fix(ci): Daily workflows report (#1200)
a3b8729 
Fix daily workflows' green tick when jobs failed.

Based of off: https://stackoverflow.com/a/58859404

Closes:  #1197

---------

Co-authored-by: Diego <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
nim-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): Daily workflows report vacp2p/nim-libp2p
2 participants
@AlejandroCabeza @diegomrsantos